chore(schema): drop dead duplicate app_organization_viewer definition#1761
Merged
Merged
Conversation
… (first entry always wins)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe predefined organization-scoped viewer role is relabeled from “Group Viewer” to “Member”; its role name, permission, and scope remain unchanged. ChangesOrganization role title
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Coverage Report for CI Build 29405295788Coverage remained the same at 45.198%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
AmanGIT07
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the second
app_organization_viewerentry fromschema.PredefinedRoles. The list has carried two definitions under the same name since #399 added one titled "Organization Group Viewer" (retitled "Group Viewer" in #1705):{ Title: "Member", Name: RoleOrganizationViewer, Permissions: []string{"app_organization_get"}, Scopes: []string{OrganizationNamespace}, }, { Title: "Group Viewer", Name: RoleOrganizationViewer, // same name, same permissions, same scopes Permissions: []string{"app_organization_get"}, Scopes: []string{OrganizationNamespace}, },Why it is dead code
The entry has never had any effect:
MigrateRoleswalks the list in order. The first entry creates (or matches) the role; when the second one runs, the role already exists. The reconcile path only rewrote a role when its permissions differed — and the two entries' permissions are identical — so the second entry never wrote anything, on any version.PredefinedRolesby name takes the first match.So the role every installation actually has is the first definition ("Member"). Removing the duplicate changes no behavior on fresh boots or upgrades; it just makes the list mean what it says.
No functional changes. Existing bootstrap and schema tests pass unchanged.