Update github extension - #30189
Conversation
- Update changelog - Implement "Clone in GitHub Desktop" action to open a repo with the desktop app.
|
Thank you for your contribution! 🎉 🔔 @thomaslombart @unnamedd @tonka3000 @khasbilegt @pernielsentikaer @loxygenK @oilbeater @LunaticMuch @aeorge @daquinoaldo @aeither @marcotf @qeude @nesl247 @xilopaint @antonengelhardt @bangerang @wottpal @LitoMore @d-mitrofanov-v @j3lte @jfkisafk @vlasischar @JavaLangRuntimeException @shyakadavis @sushichan044 @luarmr @nicolas-marien @ionTea @ridemountainpig @kud @MartinGonzalez @brandonnly @oscmarb @emergerrrd @ryo246912 @gfazioli @wonbywondev @SandeepBaskaran you might want to have a look. You can use this guide to learn how to check out the Pull Request locally in order to test it. 📋 Quick checkout commandsBRANCH="ext/github"
FORK_URL="https://github.com/workeffortwaste/raycast-extensions.git"
EXTENSION_NAME="github"
REPO_NAME="raycast-extensions"
git clone -n --depth=1 --filter=tree:0 -b $BRANCH $FORK_URL
cd $REPO_NAME
git sparse-checkout set --no-cone "extensions/$EXTENSION_NAME"
git checkout
cd "extensions/$EXTENSION_NAME"
npm install && npm run devWe're currently experiencing a high volume of incoming requests. As a result, the initial review may take up to 15 business days. |
Greptile SummaryAdds a repository action that opens the selected GitHub repository in GitHub Desktop and documents the feature in the changelog.
Confidence Score: 4/5The PR appears safe to merge, with a non-blocking action-ordering issue that should be corrected to preserve existing navigation positions. The clone URL construction matches the repository URL shape and no runtime failure was established, but the new action shifts existing action-panel entries instead of preserving their order. Files Needing Attention: extensions/github/src/components/RepositoryActions.tsx Important Files Changed
Prompt To Fix All With AI### Issue 1
extensions/github/src/components/RepositoryActions.tsx:148-154
**Preserve existing action ordering**
Inserting this action before the existing star toggle shifts that action and all following entries from their established positions, disrupting position-based navigation and muscle memory. Append the new action after the existing actions to preserve their order.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "Update github extension" | Re-trigger Greptile |
| <Action.OpenInBrowser | ||
| icon={{ source: "github.svg", tintColor: Color.PrimaryText }} | ||
| title="Clone in GitHub Desktop" | ||
| url={`x-github-client://openRepo/${repository.url}`} | ||
| onOpen={() => onVisit(repository)} | ||
| shortcut={{ modifiers: ["cmd", "shift"], key: "g" }} | ||
| /> |
There was a problem hiding this comment.
Preserve existing action ordering
Inserting this action before the existing star toggle shifts that action and all following entries from their established positions, disrupting position-based navigation and muscle memory. Append the new action after the existing actions to preserve their order.
Rule Used: What: New action panel actions should be appended ... (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: extensions/github/src/components/RepositoryActions.tsx
Line: 148-154
Comment:
**Preserve existing action ordering**
Inserting this action before the existing star toggle shifts that action and all following entries from their established positions, disrupting position-based navigation and muscle memory. Append the new action after the existing actions to preserve their order.
**Rule Used:** What: New action panel actions should be appended ... ([source](https://app.greptile.com/raycast/-/custom-context?memory=cde63d3f-214c-4294-9a2a-bb8323ef7d33))
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Description
Adds a 'Clone in GitHub Desktop' action to the repository actions, with a
Cmd+Shift+Gshortcut, which opens the selected repository in the in the GitHub Desktop app ready for cloning.Checklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare placed outside of themetadatafolder