Skip to content

[Zed] Fix project launch order - #30174

Open
szupzj18 wants to merge 1 commit into
raycast:mainfrom
szupzj18:chris/fix/zed-open-order
Open

[Zed] Fix project launch order#30174
szupzj18 wants to merge 1 commit into
raycast:mainfrom
szupzj18:chris/fix/zed-open-order

Conversation

@szupzj18

Copy link
Copy Markdown
Contributor

Fixes #30060

Root cause: Raycast 2 can tear down the extension before the Zed CLI launch starts because closeMainWindow() runs first.

Change: launch Zed before closing Raycast for single- and multi-folder CLI paths. Add an ordering regression test and changelog entry.

Validation:

  • npm test -- --run (42 passed, 3 skipped)
  • npm run lint
  • npm run build

@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: zed-recent-projects Issues related to the zed-recent-projects extension platform: macOS platform: Windows labels Aug 12, 2026
@raycastbot

Copy link
Copy Markdown
Collaborator

Thank you for your first contribution! 🎉

🔔 @ewgenius @tleo19 @jylamont @pernielsentikaer @tmwrnr @true-real-michael @remorses @vensauro @FollowTheProcess @Justin24506 @npc203 you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

📋 Quick checkout commands
BRANCH="chris/fix/zed-open-order"
FORK_URL="https://github.com/szupzj18/extensions.git"
EXTENSION_NAME="zed-recent-projects"
REPO_NAME="extensions"

git clone -n --depth=1 --filter=tree:0 -b $BRANCH $FORK_URL
cd $REPO_NAME
git sparse-checkout set --no-cone "extensions/$EXTENSION_NAME"
git checkout
cd "extensions/$EXTENSION_NAME"
npm install && npm run dev

We're currently experiencing a high volume of incoming requests. As a result, the initial review may take up to 15 business days.

@greptile-apps

greptile-apps Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Reorders Zed CLI project launching so the launch begins before Raycast closes, preventing extension teardown from interrupting it.

  • Adds a small helper that enforces open-before-close sequencing.
  • Applies the ordering to single-folder and multi-folder CLI launch paths.
  • Adds a regression test and changelog entry.

Confidence Score: 5/5

The PR appears safe to merge, with no concrete blocking or independently actionable non-blocking issues identified.

The affected single-folder and multi-folder paths now await the existing Zed CLI launch before closing Raycast, and the regression test directly checks that intended ordering.

Important Files Changed

Filename Overview
extensions/zed-recent-projects/src/search.tsx Routes both macOS CLI launch branches through the new open-before-close sequence while preserving revalidation and error handling.
extensions/zed-recent-projects/src/lib/open-project.ts Adds a helper that awaits the launch callback before invoking the close callback.
extensions/zed-recent-projects/src/lib/open-project.test.ts Verifies that the helper completes the open operation before starting the close operation.
extensions/zed-recent-projects/CHANGELOG.md Adds a correctly positioned release note using the required merge-date placeholder.

Reviews (1): Last reviewed commit: "Fix Zed project launch order" | Re-trigger Greptile

@pernielsentikaer

Copy link
Copy Markdown
Collaborator

Thanks for the fix, @ewgenius do you want to check this?

@pernielsentikaer pernielsentikaer self-assigned this Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extension fix / improvement Label for PRs with extension's fix improvements extension: zed-recent-projects Issues related to the zed-recent-projects extension platform: macOS platform: Windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Zed] zed-recent-projects's "Search Recent Projects" command does not open the selected project.

3 participants