[Zed] Fix project launch order - #30174
Conversation
|
Thank you for your first contribution! 🎉 🔔 @ewgenius @tleo19 @jylamont @pernielsentikaer @tmwrnr @true-real-michael @remorses @vensauro @FollowTheProcess @Justin24506 @npc203 you might want to have a look. You can use this guide to learn how to check out the Pull Request locally in order to test it. 📋 Quick checkout commandsBRANCH="chris/fix/zed-open-order"
FORK_URL="https://github.com/szupzj18/extensions.git"
EXTENSION_NAME="zed-recent-projects"
REPO_NAME="extensions"
git clone -n --depth=1 --filter=tree:0 -b $BRANCH $FORK_URL
cd $REPO_NAME
git sparse-checkout set --no-cone "extensions/$EXTENSION_NAME"
git checkout
cd "extensions/$EXTENSION_NAME"
npm install && npm run devWe're currently experiencing a high volume of incoming requests. As a result, the initial review may take up to 15 business days. |
Greptile SummaryReorders Zed CLI project launching so the launch begins before Raycast closes, preventing extension teardown from interrupting it.
Confidence Score: 5/5The PR appears safe to merge, with no concrete blocking or independently actionable non-blocking issues identified. The affected single-folder and multi-folder paths now await the existing Zed CLI launch before closing Raycast, and the regression test directly checks that intended ordering. Important Files Changed
Reviews (1): Last reviewed commit: "Fix Zed project launch order" | Re-trigger Greptile |
|
Thanks for the fix, @ewgenius do you want to check this? |
Fixes #30060
Root cause: Raycast 2 can tear down the extension before the Zed CLI launch starts because
closeMainWindow()runs first.Change: launch Zed before closing Raycast for single- and multi-folder CLI paths. Add an ordering regression test and changelog entry.
Validation:
npm test -- --run(42 passed, 3 skipped)npm run lintnpm run build