fix(wanda): prioritize local Docker images before falling back to remote registry#488
Open
Lucas61000 wants to merge 3 commits into
Open
fix(wanda): prioritize local Docker images before falling back to remote registry#488Lucas61000 wants to merge 3 commits into
Lucas61000 wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the image resolution logic in resolveBases to attempt local resolution before falling back to a remote registry. Feedback suggests using resolveDockerImage instead of resolveLocalImage to maintain consistency and ensure the configured Docker environment is respected. Additionally, it is recommended to remove the local resolution error from the final error message to reduce noise, as a local failure is expected in this fallback flow.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Lucas <54979663+Lucas61000@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Lucas <54979663+Lucas61000@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prioritize locally available Docker images when resolving base images, falling back to remote registry only if not found locally.