Skip to content

fix(wanda): prioritize local Docker images before falling back to remote registry#488

Open
Lucas61000 wants to merge 3 commits into
ray-project:mainfrom
Lucas61000:issue
Open

fix(wanda): prioritize local Docker images before falling back to remote registry#488
Lucas61000 wants to merge 3 commits into
ray-project:mainfrom
Lucas61000:issue

Conversation

@Lucas61000
Copy link
Copy Markdown

Prioritize locally available Docker images when resolving base images, falling back to remote registry only if not found locally.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the image resolution logic in resolveBases to attempt local resolution before falling back to a remote registry. Feedback suggests using resolveDockerImage instead of resolveLocalImage to maintain consistency and ensure the configured Docker environment is respected. Additionally, it is recommended to remove the local resolution error from the final error message to reduce noise, as a local failure is expected in this fallback flow.

Comment thread wanda/forge.go Outdated
Comment thread wanda/forge.go Outdated
Lucas61000 and others added 2 commits April 30, 2026 16:55
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Lucas <54979663+Lucas61000@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Lucas <54979663+Lucas61000@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant