Fix demo: use PHP 8 attribute instead of docblock annotation#11
Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 27 minutes and 14 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the demo Admin controller to use the PHP 8 attribute-based RequiresRoles access control instead of the legacy Doctrine docblock annotation, restoring the intended ACL behavior in the demo under PHP 8+. Class diagram for updated Admin ACL attribute usageclassDiagram
class Admin {
+createUser(id string) void
}
class RequiresRoles {
+roles array
}
Admin ..> RequiresRoles : attribute
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Summary
demo/src/Admin.phpstill used the docblock@RequiresRoles({\"login\"})which was left over from PR Remove doctrine/annotations dependency, use native PHP 8 attributes #9Test plan
Summary by Sourcery
Bug Fixes: