fix(codecompanion): support editor_context backend for MCP resource vars - #292
Open
mahsank wants to merge 1 commit into
Open
fix(codecompanion): support editor_context backend for MCP resource vars#292mahsank wants to merge 1 commit into
mahsank wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes CodeCompanion v19 compatibility for MCP resource variables in
mcphub.nvim.Root cause
mcphub.nvimassumedconfig.interactions.chat.variablesalways exists.On CodeCompanion v19, this table can be missing, which causes a startup crash when
make_vars = true(pairs()called onnil).What this changes
config.interactions.chat.variables(legacy backend)config.interactions.shared.editor_context(CodeCompanion v19+ backend)config.interactions.chat.editor_context(fallback)#{mcp:...}Related Issue(s)
pairs()invariables.lua#275Screenshots
N/A (no UI changes)
Checklist
make testto ensure all tests pass (see Notes)make formatto format the code (see Notes)make docsto update the vimdoc pages (N/A: no documentation source changes)Notes
make formatfails locally in pre-existing/unrelated files (outside this PR), due to parser errors aroundcontinuelabels.make testfails locally in an unrelated baseline test:tests/native/neovim/files/edit_file/test_edit_ui.lua | reject_all_functionalityCan not use child.lua_func because child process is blockedlua/mcphub/extensions/codecompanion/variables.lua