Enhance OpenVINO backend with view operations and new ops#157
Open
zhaixuejun1993 wants to merge 6 commits into
Open
Enhance OpenVINO backend with view operations and new ops#157zhaixuejun1993 wants to merge 6 commits into
zhaixuejun1993 wants to merge 6 commits into
Conversation
…sult, VIEW node in OpenVINO no need compare, the whole graph result is correct
wine99
reviewed
May 11, 2026
| ggml_is_view_op(g1->nodes[i]->op)) { | ||
| verified = true; | ||
| continue; | ||
| } |
Collaborator
There was a problem hiding this comment.
Can we avoid this? Hardcoding backend-specific checks for OpenVino into the GGML code isn't ideal
Collaborator
Author
There was a problem hiding this comment.
can not avoid, the VIEW op is handled in following node, which can be fused maybe, so can not compare, it has to be isolated.
Collaborator
There was a problem hiding this comment.
Is it required for a model support or unit test currently?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for the
CONCAT,ARGSORT, andSOFTPLUSoperations in the OpenVINO backend, and improves view op handling for several operators. It introduces new translation functions for these operations, updates operator tables and supported op lists, and refines how view ops are processed to improve compatibility and correctness.New OpenVINO operator support:
GGML_OP_CONCAT(concatenation) andGGML_OP_ARGSORT(argsort) in the OpenVINO backend, including new translation functions (translate_concatandtranslate_argsort), operator table entries, and support checks. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]GGML_UNARY_OP_SOFTPLUSunary operation, including the translation function and operator table entry. [1] [2] [3] [4] [5]View op handling improvements:
GET_ROWS,SILU, all 1-to-1 unary ops) to use the newprocess_view_input_newutility, ensuring correct handling of view ops as inputs. [1] [2] [3]These changes expand the set of supported operations for OpenVINO and improve robustness and compatibility when working with view-based tensors.## Overview
Additional information
Requirements