Skip to content

🎨 Palette: [UX improvement] Add context-aware confirmation dialogs and ARIA labels - #81

Open
rauhmaru wants to merge 1 commit into
mainfrom
palette-ux-aria-labels-5559698159673994292
Open

🎨 Palette: [UX improvement] Add context-aware confirmation dialogs and ARIA labels#81
rauhmaru wants to merge 1 commit into
mainfrom
palette-ux-aria-labels-5559698159673994292

Conversation

@rauhmaru

@rauhmaru rauhmaru commented Jul 9, 2026

Copy link
Copy Markdown
Owner

💡 What

Updated the generic generic removal confirmations ("Remover este produto?") to context-aware confirmations (e.g. "Remover Gin Tônica?"). I also added descriptive ARIA labels to the Edit and Remove buttons in the inventory, types, and recipe lists.

🎯 Why

This solves two user problems:

  1. The dynamic confirmation dialog now uses a data-name attribute to prevent Javascript syntax errors or injections if a product name has quotes or special characters.
  2. Screen reader users will now hear exactly which item they are editing or removing, instead of a generic action name.

📸 Before/After

Changes are structural and invisible visually; however, they significantly improve the underlying structure and assistive technology support. The confirmation popup will now properly display the name of the item.

♿ Accessibility

Applied templated aria-label attributes to action buttons which previously lacked context. Evaluated with Playwright frontend test scripts.


PR created automatically by Jules for task 5559698159673994292 started by @rauhmaru

- Use `data-name` attribute for context-aware inline confirmation dialogs to prevent JavaScript syntax errors and injection vulnerabilities.
- Add descriptive `aria-label`s to the Edit and Remove action buttons across all primary list views (Products, Types, and Cocktails) for improved screen reader accessibility.

Co-authored-by: rauhmaru <2289237+rauhmaru@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant