🛡️ Sentinel: [HIGH] Fix CSRF missing protection - #80
Conversation
Added Flask-WTF CSRFProtect globally in app.py to protect all POST, PUT, DELETE, and PATCH endpoints against Cross-Site Request Forgery.
Injected `<input type="hidden" name="csrf_token" value="{{ csrf_token() }}"/>` in all forms in Jinja templates to supply the required token.
Disabled CSRF in test client configuration (`app.config['WTF_CSRF_ENABLED'] = False`) to prevent regressions in the test suite.
Co-authored-by: rauhmaru <2289237+rauhmaru@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🚨 Severity: HIGH
💡 Vulnerability: Missing Cross-Site Request Forgery (CSRF) protection on POST forms.
🎯 Impact: Attackers could trick authenticated users into submitting unintended actions (like deleting items or adding malicious records) by hosting a hidden form on an external site that submits to our application.
🔧 Fix:
flask_wtf.CSRFProtect(app)globally inapp.py.<input type="hidden" name="csrf_token" value="{{ csrf_token() }}"/>) to all form templates.WTF_CSRF_ENABLEDintest_security.pyfixture so existing tests continue to pass in isolation..jules/sentinel.md.✅ Verification:
python -m pytestpasses, and all forms now include a hidden csrf_token field when rendered.PR created automatically by Jules for task 7874509443841725639 started by @rauhmaru