馃帹 Palette: [UX improvement] Add context-aware confirmations and ARIA labels - #79
馃帹 Palette: [UX improvement] Add context-aware confirmations and ARIA labels#79rauhmaru wants to merge 1 commit into
Conversation
Co-authored-by: rauhmaru <2289237+rauhmaru@users.noreply.github.com>
|
馃憢 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 馃憖 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
What:
Added descriptive
aria-labels to the "Editar" and "Remover" buttons invisualizar.html,visualizar_cocktails.html, andcadastrar_tipo.html. Also updated the delete confirmation dialogs to be context-aware by reading adata-nameattribute instead of using direct string interpolation.Why:
Generic labels like "Editar" or "Remover" are not helpful for screen reader users when scanning a list. Furthermore, generic "Remover este item?" confirmation dialogs leave users unsure of exactly what they are deleting. Injecting the context into the dialog improves confidence and reduces accidental deletions.
Before/After:
<button>Remover</button>andconfirm('Remover este item?')<button aria-label="Remover Gin">Remover</button>andconfirm('Remover Gin?')Accessibility:
aria-labels to the action buttons in list views so screen readers can properly identify the target of the action.data-nameto prevent string interpolation errors or vulnerabilities.PR created automatically by Jules for task 13985220115771220324 started by @rauhmaru