🎨 Palette: [UX improvement] Add context to action buttons and dialogs - #75
🎨 Palette: [UX improvement] Add context to action buttons and dialogs#75rauhmaru wants to merge 1 commit into
Conversation
- Added templated aria-labels to Edit and Remove buttons in item lists (produtos, cocktails, tipos) for better screen reader accessibility. - Enhanced delete confirmation dialogs to explicitly state the item name, reducing accidental deletions. - Refactored confirmation dialog implementations to safely use data-* attributes, preventing JS injection and syntax errors with quotes in item names. Co-authored-by: rauhmaru <2289237+rauhmaru@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What
Added dynamic
aria-labelattributes to "Edit" and "Remove" icon-only and compact buttons across all major list views (Products, Recipes, Types). Upgraded the delete confirmation dialogs to display the specific item's name before deletion.🎯 Why
Previously, screen readers would only announce "Editar" or "Remover" repeatedly without context, leaving users unsure of which item they were targeting. Additionally, the generic "Remover este produto?" confirmation was ambiguous. By providing explicit context, we improve both accessibility and general usability.
📸 Before/After
Before:
onsubmit="return confirm('Remover este produto?');"After:
data-name="Gin" onsubmit="return confirm('Remover ' + this.getAttribute('data-name') + '?');"♿ Accessibility
Screen reader users will now hear "Editar Gin" instead of just "Editar", ensuring complete context awareness when navigating tables/lists of items.
PR created automatically by Jules for task 10102558346956147578 started by @rauhmaru