fix zizmor checks, nightly builds, and update-version.sh#877
Merged
Conversation
Member
Author
|
This is failing with another error also seen in the nightlies. Sorry, I'll put this back to draft until I figure that out. |
This was referenced May 18, 2026
bdice
approved these changes
May 19, 2026
Contributor
|
I'm going to merge this to unblock #879. Thanks so much @jameslamb! If anything else is needed, feel free to ping me. |
Contributor
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few things are broken in this repo right now, this fixes them.
nightly builds
See #878
Still not sure of the exact cause, but at a step where we use
conda install pythonto upgrade/downgrade Python in thebaseenvironment, all builds where it's different from what was already installed in thecondaforge/miniforgeimage fail like this:I suspect this is due to one of these changes to
conda's import structure, maybe conda/conda#15879Force-reinstalling
condabefore any other operations fixes this.zizmor checks
When the
release/26.08branch was cut, it removed inline comments like# zizmor: ignore[unpinned-uses].Commit that broke this: 935ed5a
This causes
pre-committo fail on therelease/26.06branch with a few errors like this:This fixes that by moving that configuration into a
zizmor.ymlfile, as most other PRs in rapidsai/build-planning#275 did.update-version.shThere's one lingering
26.04reference that was missed whenrelease/26.06was cut, and one new26.06that would be missed the next time we cut a release branch.This fixes both of those.
Tested like this:
Notes for Reviewers
Running
pre-commit run --all-filesbefore pushing that release commit would have caught thezizmorissue.