Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Fixed missing argument to factory closure which caused window to be null in IE10#30

Open
auchenberg wants to merge 2 commits into
rapid7:masterfrom
auchenberg:master
Open

Fixed missing argument to factory closure which caused window to be null in IE10#30
auchenberg wants to merge 2 commits into
rapid7:masterfrom
auchenberg:master

Conversation

@auchenberg

Copy link
Copy Markdown

Fixed missing argument to factory closure which caused window to be null in IE10.

Exception thrown in IE:

SCRIPT5007: Unable to get property 'location' of undefined or null reference

File: le.js, Line: 59, Column: 13

Fixed missing argument to factory closure which caused window to be null in IE10.
@m0wfo

m0wfo commented Dec 11, 2014

Copy link
Copy Markdown
Contributor

@auchenberg thanks for this! It looks like the tests aren't happy for some reason so I'll fix them before I merge this.

@auchenberg

Copy link
Copy Markdown
Author

Ahh. I see why. Since I'm now passing an argument to the closure, the function is executed and therefore not returning anything.

Either the inner function should be wrapped in

return function() { 
// func
} 

or we simply should pass window to the closure as an argument.

@m0wfo

m0wfo commented Dec 11, 2014

Copy link
Copy Markdown
Contributor

@auchenberg Either way the tests should fail in their current state- we need to look into this first.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants