Replace local isRecord guards with Valibot schemas#1416
Open
simple-agent-manager[bot] wants to merge 5 commits into
Open
Replace local isRecord guards with Valibot schemas#1416simple-agent-manager[bot] wants to merge 5 commits into
simple-agent-manager[bot] wants to merge 5 commits into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
isRecordhelpers in apps, scripts, and experiments with Valibot schemas or custom Valibot predicates.sync-wrangler-configso validated TOML maps still mutate the original config object.Coverage
apps/api/src/durable-objects/project-orchestrator/scheduling.tsapps/web/src/pages/sam-prototype/onboarding-cards.tsxscripts/deploy/sync-wrangler-config.tsscripts/quality/check-preflight-evidence.tsscripts/quality/check-specialist-review-evidence.tsscripts/quality/check-observability-noise.tsexperiments/ai-gateway-tool-call/experiment.tsexperiments/harness-eval/runner.tsValidation
rg -n "\bisRecord\b" apps scripts experiments packages || truereturned no matches.pnpm --filter @simple-agent-manager/api typecheckpnpm --filter @simple-agent-manager/web typechecktsc --noEmitcompile for touched scripts and experiments.pnpm quality:specialist-review:test(68 tests passed).pnpm lintpassed with pre-existing warnings only.28183922752including deploy, health check, and smoke tests.Notes
28183565999caught a real regression in the initial Valibot conversion: validating TOML maps through parsed output lost mutations on cloned objects. Fixed in65ff0146by validating but returning the original TOML map, with test coverage added.Do not merge until explicitly approved.