chore: acp-kernel 0.0.34, drop demoted mirror retry (kernel PR 112) - #125
Merged
Conversation
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps acp-kernel 0.0.33 → 0.0.34 and removes the omp-side demoted-mirror retry that #124 added — the kernel now owns that problem.
Why
acp-kernel PR #112 (v0.0.34) makes
openaiToCoresplit inline demoted<think>…</think>content, so hosts that demote thinking inline (glm / qwen3 / deepseek / kimi profiles) and hosts that use thereasoning_contentfield land in one identity space. Two serializations of the same turn now yield the same core sequence / fingerprints, therefore:demoteThinkingmirror variant inviewToCoreStreamis dead weight,primeFoldrefold retry inruntime.tscan never fire (condition: zero blocks replayed) — the default mirror replays fine on the first fold.Protocol knowledge consolidates in the kernel per the architecture direction: omp stops hand-rolling a second serialization.
Changes
package.json/package-lock.jsonsrc/runtime.tsopenaiSystemstash +let rsimplifiedsrc/wire-fold.tsviewToCoreStreamback to single mirror;opts.demoteThinkingremovedtests/wire-transform.test.tsreasoning_contentmirror under kernel 0.0.34 (asserts the bump is load-bearing)tests/prime-provider-restart.test.tsTests
bun test260/260 (demoted e2e restart test passes without retry)tsc --noEmit+tsc -p tsconfig.test.jsoncleanCloses the omp side of the issue #64 demoted variant.