fix: match nested blocks by any visible representation in range - #124
Merged
Conversation
…ion-context-pi#195 follow-up)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #119 (billion-context-pi#195).
Regression found in e2e
billion-context-pi e2e scenario
05-multiple-compressionsfails on 0.0.38:activeBlockCount === 1 — got 2. The second compression (m-ref range over thewhole visible history) no longer consumes the first block.
Root cause
When a block covers the session's first user message, prune keeps that one
raw (first-user exception) and inserts the rendered summary at the block's
earliest raw position — i.e. before the surviving raw. The summary index
then sits outside an m-ref range that still contains the raw.
#119's nested discovery used
visibleBlockAnchor(summary-preferred) for rangemembership, so the block was missed → not consumed → left active. Pre-0.0.36
code used raw-only anchors, which is why this geometry worked before.
Fix
New exported
blockVisibleInRange(block, indexByMessageId, start, end): ablock participates in a range when any visible representation (rendered
summary OR earliest surviving raw) falls inside it. Used at both nested
discovery sites:
resolveBoundariesinitial scan (src/boundaries.ts)applySingleRangerescan after pair-boundary adjustment (src/compress.ts)Anchor resolution for bN refs (
visibleBlockAnchor) is unchanged.Validation
summary precedes surviving raw; m-ref range must consume it). Fails without
the fix.
(05-multiple-compressions: blockCount=2, activeBlockCount=1, compressionCount=2).
Release note
0.0.38 (already published) does NOT contain this fix. Downstream release
branches (pi v0.1.46 / omp v0.3.2 / billion-context) should pin v0.0.39
once this lands.