fix: address PR 387 review feedback#1
Open
ranxi2001 wants to merge 2 commits into
Open
Conversation
Signed-off-by: ranxi2001 <ranxi169@163.com>
Signed-off-by: ranxi2001 <ranxi169@163.com>
5316358 to
5867183
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked validation PR for upstream volcano-sh#387.
This PR is intentionally based on
feat/agent-sandbox-latest, notmain, so the review surface only contains fixes for PR volcano-sh#387 feedback and CI failures. After validation, the clean fix commit can be cherry-picked/rebased back intofeat/agent-sandbox-latest.Changes:
lintandtest-coverageworkflows withgo.modtarget Go1.26.2.handleSandboxCreatecomplexity by extracting sandbox create error handling.Sandbox -> PodownerRefs.EntryPoints.Validation:
go test ./pkg/workloadmanager -count=1go test ./test/e2e -run TestNonExistent -count=1make lintgo test -race -v -coverprofile=coverage.out -coverpkg=./pkg/... ./pkg/...go test -race ./pkg/workloadmanager -count=1go test ./pkg/... -count=1git diff --checkKnown local limitation:
go test ./... -count=1fails only intest/e2ewhen local Router / WorkloadManager are not running and no kubeconfig is configured. The non-e2e package set passes.AI assistance: Used Codex to inspect CI logs, implement the fix, and run local validation. I reviewed the changes and test output.