Remove RKE1 related code#613
Open
pmatseykanets wants to merge 3 commits into
Open
Conversation
RKE1 types (NodePool, RancherKubernetesEngineConfig, NetworkConfig) were removed from rancher/rancher in rancher/rancher#54586. Drop all CLI code that depended on these types: - cluster create: remove --disable-docker-version, --import, --k8s-version, --network-provider, --rke-config flags and the RKE engine config block - cluster add-node: remove NodePool.List() guard; simplify to check cluster.Driver == "" for custom clusters - nodes ls: remove POOL column and getNodePools/getNodePoolName helpers - common: remove readFileReturnJSON, hasPrefix (now dead)
pmatseykanets
requested review from
a team,
JonCrowther,
andreas-kupries,
bhartigautam156,
bigkevmcd and
kinarashah
Node.SshUser was removed in rancher/rancher#54586 alongside NodePool. Refactor getNodeAndKey to return sshUser as a separate value instead of storing it on the Node struct. Also remove convertSnakeCaseKeysToCamelCase, renameKeys, and their tests — these were only used by the rke-config import path that was already removed.
andreas-kupries
approved these changes
Jun 24, 2026
bigkevmcd
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
RKE1 types (NodePool, RancherKubernetesEngineConfig, NetworkConfig, Node.SshUser) were removed from rancher/rancher in rancher/rancher#54586.
Solution
Drop all code that depended on these types:
Note: rancher/rancher will be updated in #612