feat(hermes): add pr2046 class-in-finally var caching patch#51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the
hermessource patch for facebook/hermes#2046, a cherry-pick of1e94fbe0ebonto the250829098.0.0-stablebranch React Native 0.85 ships.A
finallyblock emits its body twice. On the second emission, legacy class compilation built fresh internal Variables (class/prototype vars, the instance-element init function, computed field keys, private brands) while cached functions reached viafindCompiledEntitystill referenced the originals, miscompiling classes declared infinally. The cherry-pick caches them in aLegacyClassVarsstruct keyed by the class AST node and emits private-brand stores unconditionally.Source-level replacement for the class-in-finally workaround dropped with
@react-native/babel-preset#56816. Apply withgit applyagainst afacebook/hermesV1 checkout. Root cause facebook/hermes#1761.packages/hermes/hermes-pr2046.patchhermesrow to the Open table