Fix health status namespace header#398
Open
eagle27272 wants to merge 1 commit into
Open
Conversation
eagle27272
marked this pull request as ready for review
July 10, 2026 13:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
X-Vault-NamespaceforGetHealthStatusAsyncrequestsWhy
HashiCorp documents
/sys/healthas a restricted endpoint and states that clients must call it from the root namespace: https://developer.hashicorp.com/vault/api-docs/system/healthWhen
VaultClientSettings.Namespaceis configured, VaultSharp currently sendsX-Vault-Namespaceon health checks, which makes the request target a namespace even though the endpoint is only valid at root.Validation
dotnet build src/VaultSharp/VaultSharp.csproj -f netstandard2.0 --no-restoreNotes
CONTRIBUTING.MDasks contributors to run theVaultSharp.Samplesconsole app. I did not run it here because it requires a local Vault server athttp://localhost:8200with the sample setup.