Read trades from derived table#2589
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label Raindex-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |

Chained PRs
Depends on #2588. Stack order: #2587 -> #2588 -> #2589 -> #2590
Motivation
The slow trade endpoints come from reconstructing trades from event tables on every read. Once the sync pipeline maintains
derived_trades, the SDK read path should query that table directly.Solution
fetch_tradesandfetch_trades_countto read fromderived_trades.Local performance check
On the locally synced Base ST0x DB for
0xe522cB4a5fCb2eb31a52Ff41a4653d85A4fd7C9D, USDC matched 9,813 derived rows. The SDK local DB path averaged about 8.7ms for page + exact count over 100 iterations.Checks
COMMIT_SHA=local nix develop -c cargo test -p raindex_common local_db::query --libCOMMIT_SHA=local nix develop -c cargo test -p raindex_common local_db::pipeline::adapters::apply --libCOMMIT_SHA=local nix develop -c cargo test -p raindex_common local_db::export --libCOMMIT_SHA=local nix develop -c cargo test -p raindex_common raindex_client::trades --lib