Skip to content

Read trades from derived table#2589

Open
findolor wants to merge 1 commit into
arda/derived-trades-maintenancefrom
arda/derived-trades-read-path
Open

Read trades from derived table#2589
findolor wants to merge 1 commit into
arda/derived-trades-maintenancefrom
arda/derived-trades-read-path

Conversation

@findolor
Copy link
Copy Markdown
Collaborator

@findolor findolor commented May 22, 2026

Chained PRs

Depends on #2588. Stack order: #2587 -> #2588 -> #2589 -> #2590

Motivation

The slow trade endpoints come from reconstructing trades from event tables on every read. Once the sync pipeline maintains derived_trades, the SDK read path should query that table directly.

Solution

  • Rewrite generic fetch_trades and fetch_trades_count to read from derived_trades.
  • Update owner, order-hash, and transaction trade query paths to use the derived table.
  • Preserve token metadata joins only for returned page rows instead of joining event tables across the full candidate set.
  • Keep existing filters for token input/output, owner, taker, order hash, transaction hash, time range, and pagination.

Local performance check

On the locally synced Base ST0x DB for 0xe522cB4a5fCb2eb31a52Ff41a4653d85A4fd7C9D, USDC matched 9,813 derived rows. The SDK local DB path averaged about 8.7ms for page + exact count over 100 iterations.

Checks

  • COMMIT_SHA=local nix develop -c cargo test -p raindex_common local_db::query --lib
  • COMMIT_SHA=local nix develop -c cargo test -p raindex_common local_db::pipeline::adapters::apply --lib
  • COMMIT_SHA=local nix develop -c cargo test -p raindex_common local_db::export --lib
  • COMMIT_SHA=local nix develop -c cargo test -p raindex_common raindex_client::trades --lib

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 22, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: cbfa5a1f-796c-490c-84b2-402d632ab77d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch arda/derived-trades-read-path

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Collaborator Author

findolor commented May 22, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label Raindex-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant