refactor: use versioned soldeer paths in imports#58
Conversation
Previously this package used custom remappings to keep the rain.interpreter.interface/... and rain.math.float/... namespace-style paths in source. That worked for our own build but pushed extra burden onto consumers: anything depending on raindex-interface had to also remap those namespaces, because Solc resolves imports in our source through the CONSUMERs remappings, not ours. Switch to the versioned soldeer paths directly so consumers can just pull raindex-interface and have its internal imports resolve via the auto-generated remappings.txt soldeer install produces. Bumps the minor version when this lands.
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (8)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment: S/M/L PR Classification Guidelines:This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed. Small (S)Characteristics:
Review Effort: Would have taken 5-10 minutes Examples:
Medium (M)Characteristics:
Review Effort: Would have taken 15-30 minutes Examples:
Large (L)Characteristics:
Review Effort: Would have taken 45+ minutes Examples:
Additional Factors to ConsiderWhen deciding between sizes, also consider:
Notes:
|
1 participant
Switches
src/imports from namespace-style (rain.interpreter.interface/...,rain.math.float/...) to versioned soldeer paths (rain-interpreter-interface-0.1.0/src/...,rain-math-float-0.1.1/src/...).Why
Solc resolves imports through the CONSUMER's remappings, not this package's. v0.1.0 used custom
rain.interpreter.interface/=…andrain.math.float/=…remappings infoundry.tomland worked locally, but any consumer (e.g. raindex's soldeer migration) had to add those same custom remappings to make this package's internal imports resolve.With versioned paths the internal imports resolve via the auto-generated
remappings.txtthatforge soldeer installproduces for every consumer — no extra config needed.Changes
src/imports:rain.interpreter.interface/…→rain-interpreter-interface-0.1.0/src/…,rain.math.float/…→rain-math-float-0.1.1/src/…(8 files, 23 imports rewritten)foundry.toml: dropped the now-unused customremappings = […]section.gitignore:*.zip(dry-run artifacts)After merge, tag v0.1.1 so consumers can bump.
🤖 Generated with Claude Code