ci: skip foundry.lock + .gitignore from soldeer publishes#57
Conversation
Soldeer flags both as sensitive and prompts interactively on push. CI has no TTY so the prompt fails with not connected and the publish dies. Neither file is actually sensitive (no secrets) and consumers have no use for them either, so the simplest fix is to exclude them from the publish payload via .soldeerignore.
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughUpdated ChangesSoldeer Configuration
🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.soldeerignore:
- Line 1: Add the required REUSE headers to the top of .soldeerignore by
inserting SPDX-FileCopyrightText and SPDX-License-Identifier tags (e.g., add a
line with SPDX-FileCopyrightText: <year> <copyright holder> and a line with
SPDX-License-Identifier: <license-id>) so the REUSE linter recognizes the file;
ensure the headers are the very first non-blank lines in the file and use the
correct year, copyright holder, and license identifier for the project.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
| @@ -0,0 +1,7 @@ | |||
| # Soldeer flags .gitignore and foundry.lock as "sensitive" and prompts | |||
There was a problem hiding this comment.
Critical: Add required REUSE copyright and licensing headers.
The pipeline is failing because .soldeerignore lacks required REUSE compliance headers. Add SPDX-FileCopyrightText and SPDX-License-Identifier tags at the top of the file to satisfy the REUSE lint check.
📋 Proposed fix to add REUSE headers
+# SPDX-FileCopyrightText: 2026 Rain Language
+# SPDX-License-Identifier: CAL-1.0
+
# Soldeer flags .gitignore and foundry.lock as "sensitive" and prompts📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| # Soldeer flags .gitignore and foundry.lock as "sensitive" and prompts | |
| # SPDX-FileCopyrightText: 2026 Rain Language | |
| # SPDX-License-Identifier: CAL-1.0 | |
| # Soldeer flags .gitignore and foundry.lock as "sensitive" and prompts |
🧰 Tools
🪛 GitHub Actions: rainix / 2_rainix _ legal _ legal.txt
[error] 1-1: REUSE lint failed: missing copyright and licensing information for .soldeerignore. Add 'SPDX-FileCopyrightText' and 'SPDX-License-Identifier' tags.
🪛 GitHub Actions: rainix / rainix _ legal _ legal
[error] 1-1: REUSE lint failed: missing copyright and licensing information. Tool listed .soldeerignore as lacking required REUSE tags (SPDX-FileCopyrightText / SPDX-License-Identifier).
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.soldeerignore at line 1, Add the required REUSE headers to the top of
.soldeerignore by inserting SPDX-FileCopyrightText and SPDX-License-Identifier
tags (e.g., add a line with SPDX-FileCopyrightText: <year> <copyright holder>
and a line with SPDX-License-Identifier: <license-id>) so the REUSE linter
recognizes the file; ensure the headers are the very first non-blank lines in
the file and use the correct year, copyright holder, and license identifier for
the project.
Matches the canonical pattern shared across rain.deploy, rain.factory, rain.extrospection etc. — excludes the full set of dev-machinery files (audit/, cache/, dependencies/, flake.*, slither.config.json, REUSE.toml, etc.) that consumers of the package have no use for and that soldeer would otherwise flag as sensitive on push.
reuse lint flagged the new .soldeerignore as missing copyright info. Add it to the same blanket annotation as the other dev config files.
|
@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment: S/M/L PR Classification Guidelines:This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed. Small (S)Characteristics:
Review Effort: Would have taken 5-10 minutes Examples:
Medium (M)Characteristics:
Review Effort: Would have taken 15-30 minutes Examples:
Large (L)Characteristics:
Review Effort: Would have taken 45+ minutes Examples:
Additional Factors to ConsiderWhen deciding between sizes, also consider:
Notes:
|
|
Tip For best results, initiate chat on the files or code changes. SIZE=S |
1 participant
Adds
.soldeerignoreexcludingfoundry.lockand.gitignorefromforge soldeer push.Soldeer flags both filenames as sensitive and prompts interactively before continuing the push. CI doesn't have a TTY on stdin, so the prompt fails with
error during IO operation for '': not connectedand the whole publish aborts. The v0.1.0 publish has hit this twice already (runs 26237044461 and 26237910066).Neither file actually contains secrets — they're just on soldeer's hardcoded sensitive-name list. Consumers of the package have no use for them either, so the simplest fix is to exclude them from the publish payload.
After merge, retagging v0.1.0 will retrigger the publish and should succeed.
🤖 Generated with Claude Code
Summary by CodeRabbit