Show auto-detected cooldown source at normal log level; fix test isolation#1662
Open
bayraak wants to merge 2 commits intoraineorshine:mainfrom
Open
Show auto-detected cooldown source at normal log level; fix test isolation#1662bayraak wants to merge 2 commits intoraineorshine:mainfrom
bayraak wants to merge 2 commits intoraineorshine:mainfrom
Conversation
…est isolation When cooldown is auto-detected from package manager configs (.npmrc min-release-age, pnpm-workspace.yaml minimumReleaseAge, .yarnrc.yml npmMinimalAgeGate), the info message was only visible with --verbose. This made it confusing when packages were silently skipped. Show the cooldown source at normal log level, consistent with existing messages like "Using config file ..." and "Using yarn/pnpm". Also fix test isolation: pnpm/yarn cooldown tests did not stub findNpmConfig, causing failures when the user's ~/.npmrc contains min-release-age. Fixes raineorshine#1661
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.npmrcmin-release-age,pnpm-workspace.yamlminimumReleaseAge,.yarnrc.ymlnpmMinimalAgeGate) at normal log level instead of verbose-only. This is consistent with existing messages likeUsing config file ...andUsing yarn/pnpm.findNpmConfig, causing 4 test failures when the user running tests hasmin-release-ageset in their~/.npmrc.Before: No output at normal level when cooldown is auto-detected — packages silently skipped.
After:
Fixes #1661
Test plan
ncuwithmin-release-agein.npmrcand confirm the message appears without--verbose