Skip to content

fix: Prevent Connection Leak to Pool on Context Cancellation #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
key1989han wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Prevent Connection Leak to Pool on Context Cancellation #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions fix.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
package fix

import (
"context"
"database/sql"
)

// FixConnectionLeak ensures connections are properly returned to the pool
// when context is cancelled, preventing connection leaks.
func QueryWithContext(ctx context.Context, db *sql.DB, query string, args ...interface{}) (*sql.Rows, error) {
conn, err := db.Conn(ctx)
if err != nil {
return nil, err
}
defer conn.Close()
return conn.QueryContext(ctx, query, args...)
}