This repository was archived by the owner on Apr 8, 2024. It is now read-only.
Fixing #3 issue by intoducing one new env var and changing start command. - #4
Open
alexbalandi wants to merge 6 commits into
Open
Fixing #3 issue by intoducing one new env var and changing start command.#4alexbalandi wants to merge 6 commits into
alexbalandi wants to merge 6 commits into
Conversation
Author
|
I'm quite sure the changes work, it's just that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems the problem of #3 is actually a semantics change in v 1.x of n8n : https://community.n8n.io/t/n8n-1-x-not-starting-well/28619
rather than do
n8n startit's enough to just dostartnow.I also introduced defult env var for TINI to avoid this warning : [WARN tini (7)] Tini is not running as PID 1 and isn't registered as a child subreaper.
It seems just changing run command to "start" in config is not enough, but changing dockerfile in proposed way seems to work if i deploy from by branch. I will try now to set up full-blown template of mine to make sure this works.