Mark LockfileCheck as completed if all gems are skipped#235
Merged
Conversation
etagwerker
approved these changes
Jun 10, 2026
etagwerker
left a comment
etagwerker
left a comment
Member
There was a problem hiding this comment.
@arielj Looks good, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #231
When processing a lockfile, if all the gems are skipped (either source is not valid or version is not defined), no GemCheck background job was added to the queue, so nothing was getting processed and the LockfileCheck object was never updated.
Now, if there are no GemChecks to enqueue, we change the status to
completeright away.I used this lockfile to test this (it's the lockfile of this project but using the gems.coop source)
Gemfile.lock.zip