Skip to content

Add support for ignoring nil values in Jbuilder scope#580

Draft
moritonal wants to merge 3 commits intorails:mainfrom
moritonal:548-Fix-for-nested-ignore
Draft

Add support for ignoring nil values in Jbuilder scope#580
moritonal wants to merge 3 commits intorails:mainfrom
moritonal:548-Fix-for-nested-ignore

Conversation

@moritonal
Copy link
Copy Markdown

Okay, this isn't clear to merge yet. I'm doing this to see how the Actions run because I think there's currently a bug in it's building.

@moritonal
Copy link
Copy Markdown
Author

Okay, so it's not just me, the actions are all failing on

/home/runner/work/jbuilder/jbuilder/vendor/bundle/ruby/3.0.0/gems/activesupport-7.0.8.7/lib/active_support/logger_thread_safe_level.rb:12:in `<module:LoggerThreadSafeLevel>': uninitialized constant ActiveSupport::LoggerThreadSafeLevel::Logger (NameError)
	from /home/runner/work/jbuilder/jbuilder/vendor/bundle/ruby/3.0.0/gems/activesupport-7.0.8.7/lib/active_support/logger_thread_safe_level.rb:9:in `<module:ActiveSupport>'

@moritonal
Copy link
Copy Markdown
Author

Okay, Ruby isn't my primary language so any advice is welcome on how to improve this. But it should fix up the issue whereby nested null's aren't processed correctly.

@moritonal
Copy link
Copy Markdown
Author

Attempts to solve #363

JuanVqz added a commit to fastruby/points that referenced this pull request May 5, 2026
jbuilder 2.11.x calls require "active_support/proxy_object" at
load time. proxy_object was deprecated in Rails 5 and removed in
Rails 8.0, so the require raises LoadError the moment Bundler
runs Bundler.require for the :default group:

  LoadError: cannot load such file -- active_support/proxy_object
    config/application.rb:7:in `<top (required)>'

jbuilder 2.12 dropped the require (jbuilder commit b8e2d8f),
2.13 added explicit Rails 8 support. Bumping the floor to 2.13
resolves cleanly on both 7.2 (current) and 8.0 (next), so this
sits as a prereq before the Rails version flip.

Conservative resolution kept all other gems pinned.

Ref: rails/jbuilder#580
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant