Skip to content

Features/blog details jisan#49

Open
jisanahamed09205 wants to merge 11 commits into
masterfrom
features/blog_details_jisan
Open

Features/blog details jisan#49
jisanahamed09205 wants to merge 11 commits into
masterfrom
features/blog_details_jisan

Conversation

@jisanahamed09205

Copy link
Copy Markdown
Collaborator

all component and section are okay. but there is code optimize, dynamic all data, destracture are not ok.

@vercel

vercel Bot commented Dec 29, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medicare ❌ Failed (Inspect) Jan 2, 2025 1:04pm

return (
<div className="max-w-5xl mx-auto bg-white shadow-md rounded-lg p-6">
<h2 className="text-2xl font-semibold mb-6">
Total Comment ({comments.length.toString().padStart(2, "0")})

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use like this convertNumToPad(size(comments) || 0) helper function from appHelper.

Please do import size from lodash

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i tried this way but it's not working Total Comment ({convertNumToPad(comments.length)})

Comment thread src/components/BlogDetails/BlogDetailsComponents/BlogComment.jsx
Comment thread src/components/BlogDetails/BlogDetailsComponents/BlogComment.jsx
Comment thread src/components/BlogDetails/BlogDetailsComponents/BlogComment.jsx Outdated
Comment thread src/components/BlogDetails/BlogDetailsComponents/BlogComment.jsx Outdated
Comment thread src/components/BlogDetails/BlogDetailsComponents/SearchAndCategories.jsx Outdated
Comment thread src/components/BlogDetails/BlogDetailsComponents/SearchAndCategories.jsx Outdated
Comment on lines +3 to +6
import BlogHeader from "./BlogDetailsComponents/BlogHeader";
import BlogComment from "./BlogDetailsComponents/BlogComment";
import BlogCommentForm from "./BlogDetailsComponents/BlogCommentForm";
import BlogSidebar from "./BlogDetailsComponents/BlogSidebar";

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use absolute import from now.

@jisanahamed09205 jisanahamed09205 Dec 31, 2024

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but it's not working

Comment thread src/components/BlogDetails/BlogDetailsPage.jsx Outdated
Comment thread src/components/BlogDetails/BlogDetailsPage.jsx

@rahat2020 rahat2020 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try to solve the feedback asap.

Comment on lines +2 to +4
import SearchAndCategories from "./SearchAndCategories";
import RecentPost from "./RecentPost";
import PostTags from "./PostTags";

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import like this: '@/components/BlogDetails/BlogSidebar'

placeholder="Search..."
className="w-full px-4 py-2 border rounded-lg focus:outline-none focus:ring-2 focus:ring-blue-400"
/>
<button

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try to fix it otherwise let me know, and we will discuss it.

…racture and make code readable, clean, reuseable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants