[Router] Remove unused custom constraint scaffold - #378
Open
RedZapdos123 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Mridankan Mandal <xerontitan90@gmail.com>
RedZapdos123
force-pushed
the
router/remove-custom-constraint-scaffold
branch
from
August 2, 2026 07:04
1cabeee to
87d0fa5
Compare
Contributor
Author
|
This is an internal router cleanup with no runtime behavior or public API change, so no need to add a changelog entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR removes unused router custom constraint scaffold.
The router only supports host constraints as of the latest main.
Rage::Router::Backendalways buildsRage::Router::Constrainerwithout any custom strategies in practice, and the constrainer never uses the constructor argument.This PR removes the unused constructor path and dead helper without changing router behavior.
Checklist:
bundle exec rubocop --format simple lib/rage/router/constrainer.rb lib/rage/router/backend.rb.bundle exec rspec spec/router.