Update on_finish use the span saved on the request env - #2
Open
rsamoilov wants to merge 1 commit into
Open
Conversation
Previously, `on_finish` was still getting the span from `Rack.current_span`. When running in a different fiber, `Rack.current_span.recording? == false`, so `add_response_attributes` was skipped. The fix makes `on_finish` use the stored Rack request context when finishing spans - this keeps response attributes and error status on the original server span.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
on_finishwas still getting the span fromRack.current_span. When running in a different fiber,Rack.current_span.recording? == false, soadd_response_attributeswas skipped.The fix makes
on_finishuse the stored Rack request context when finishing spans - this keeps response attributes and error status on the original server span.