fix: Update Rack context management to use hash - #1
Merged
Conversation
Now, the request itself will be attached to its context in a hash, allowing the specific context associated with that hash to be detached on finish. This should resolve issues with fiber-based frameworks and Sinatra environments that mount multiple apps.
3 tasks
rsamoilov
approved these changes
Aug 14, 2026
rsamoilov
merged commit Aug 14, 2026
fa8b087
into
rage-rb:fix/rack-fiber-safe-context-detachment
11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now, the request itself will be attached to its context in a hash, allowing the specific context associated with that hash to be detached on finish.
This should resolve issues with fiber-based frameworks and Sinatra environments that mount multiple apps.
Relates to:
EventHandleropen-telemetry/opentelemetry-ruby-contrib#2130