fix(setup-r): export correct RTOOLS HOME env vars on Windows ARM64 and x64 - #1104
Open
vjymisal0 wants to merge 1 commit into
Open
fix(setup-r): export correct RTOOLS HOME env vars on Windows ARM64 and x64#1104vjymisal0 wants to merge 1 commit into
vjymisal0 wants to merge 1 commit into
Conversation
…d x64 On windows-11-arm runners, RTOOLS45_AARCH64_HOME (or RTOOLS44_AARCH64_HOME) should be exported to point to the ARM64 toolchain directory rather than leaving the ARM64 variable unset and defaulting to x86_64 paths. Closes r-lib#1102 Signed-off-by: vjymisal0 <vijay.looprai@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2-branch #1104 +/- ##
==========================================
Coverage 83.33% 83.33%
==========================================
Files 3 3
Lines 12 12
==========================================
Hits 10 10
Misses 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1102.
On
windows-11-armrunners,RTOOLS45_AARCH64_HOME(orRTOOLS44_AARCH64_HOME) was unset whileRTOOLS45_HOMEwas pointing to thex86_64toolchain path, breaking downstream workflows performing toolchain lookups.Changes
setup-r/src/installer.ts, exportRTOOLS45_AARCH64_HOME/RTOOLS44_AARCH64_HOMEwhenARCH === 'arm64'.RTOOLS45_HOME/RTOOLS44_HOME/RTOOLS43_HOME/RTOOLS42_HOME/RTOOLS40_HOMEonx64.