Fix commits rest api#719
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub commits fetch logic used by the contributors.astro component, aiming to align it with the GitHub REST API limits and to fail fast with a clearer error when the API response is not the expected shape.
Changes:
- Reduce
per_pagefrom 1000 to 100 to match GitHub’s documented maximum for the commits endpoint. - Add validation to ensure the commits response is an array, throwing a descriptive error if not.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://happy-mushroom-0564bdf0f-719.eastus2.5.azurestaticapps.net |
…ent cuz copilot be nitpicky)
Contributor
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://happy-mushroom-0564bdf0f-719.eastus2.5.azurestaticapps.net |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.