Restore compact model forwarding settings#296
Open
OLuckyO wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds support in the admin settings UI for configuring “compact” model forwarding rules (for /v1/responses/compact) alongside the existing model forward rules.
Changes:
- Introduces new draft state and normalization for
compactModelForwardRules. - Adds update/commit handlers to persist
compactModelForwardRulesto settings. - Adds a new
ModelForwardRulesEditorsection for compact routing rules in the Settings page.
Comments suppressed due to low confidence (1)
apps/src/app/settings/page.tsx:2
- Normalization is applied redundantly:
updateCompactModelForwardRuleRowsalready callsensureModelForwardRuleRows(sourceRows)before invoking the updater, butonRowsChangewraps the updater with anotherensureModelForwardRuleRows(updater(rows)). This duplication makes it harder to reason about invariants and can add unnecessary work. Centralize normalization in one place (preferably insideupdateCompactModelForwardRuleRows) and haveonRowsChangepass the updater through directly. Also consider ensuring rows right before serialization incommitCompactModelForwardRulesDraftto guarantee the persisted format is normalized even if future callers update the draft without ensuring.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+776
to
+781
| const sourceRows = | ||
| compactModelForwardRuleRowsDraft ?? | ||
| parseModelForwardRules(snapshot?.compactModelForwardRules || ""); | ||
| setCompactModelForwardRuleRowsDraft( | ||
| updater(ensureModelForwardRuleRows(sourceRows)), | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores the compact model forwarding rules editor in Settings so persisted compactModelForwardRules can be reviewed and updated.