SSL certificate fix#317
Open
philip-peterson wants to merge 1 commit into
Open
Conversation
Corporate proxies that perform SSL inspection intercept HTTPS traffic
and re-encrypt it using a self-signed certificate chain. Node.js has its
own trust store separate from the OS/browser, so it rejects these certs
by default, causing `hyper search` to fail with:
RequestError: self signed certificate in certificate chain
Two fixes:
1. Pass `https: { rejectUnauthorized }` to got, reading from
NODE_TLS_REJECT_UNAUTHORIZED. Setting that env var to '0' bypasses
SSL verification for the npms.io search request.
2. Detect certificate errors in the search/ls-remote error handlers and
print an actionable hint instead of the raw error object.
The proper long-term fix is to add the corporate CA cert to Node's trust
store via NODE_EXTRA_CA_CERTS. See also issue #316 which tracks replacing
got with native fetch (which requires a different approach to SSL bypass
via a custom undici.Agent).
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude says:
SSL certificate warning
Corporate proxies that perform SSL inspection intercept HTTPS traffic
and re-encrypt it using a self-signed certificate chain. Node.js has its
own trust store separate from the OS/browser, so it rejects these certs
by default, causing
hyper searchto fail with:RequestError: self signed certificate in certificate chain
Two fixes:
https: { rejectUnauthorized }to got, reading fromNODE_TLS_REJECT_UNAUTHORIZED. Setting that env var to '0' bypasses
SSL verification for the npms.io search request.
print an actionable hint instead of the raw error object.
The proper long-term fix is to add the corporate CA cert to Node's trust
store via NODE_EXTRA_CA_CERTS. See also issue #316 which tracks replacing
got with native fetch (which requires a different approach to SSL bypass
via a custom undici.Agent).