workspace: add the Anchor programs CI never linted

[mikemaccana]

Stacked on #123. Retarget to main once that merges, and do not merge this into a dead branch. The two commits here need the v2 port because the dependency conflict below only exists under anchor-spl 2.0.0-rc.1.

cargo fmt --check and cargo clippy -- -D warnings run from the repository root and only see members of the root workspace. 32 Anchor programs were not members, so CI had never looked at them. This takes the workspace from 61 members to 101.

They used to be members. The original workspace in 17afe2e7 (2023) listed the tokens, compression and oracles programs alongside basics. a70c93ba (2024), whose subject is "test: Adding test jobs github actions for anchor and solana native", deleted every member after basics/transfer-sol without mentioning it. The native token entries have been re-added one at a time since, as people touched them; the Anchor ones never were. No commit message, comment or issue justifies the omission.

Three structural fixes were needed

• Five transfer-hook examples all named their crate transfer-hook, and one workspace cannot hold two packages with the same name. Each package name now carries its variant. [lib] name stays transfer_hook, so Anchor.toml, the IDL and the .so are untouched, and nothing path-depends on these crates.
• Six Anchor programs genuinely use anchor-spl's metadata feature, which requires mpl-token-metadata =5.1.2-alpha.2. A caret range excludes pre-releases, so the five native token programs asking for ^5.1.1 could not share a lockfile with them. The native programs now match the pin. That also required bumping their aliased mpl-solana-program from 2.3 to 3.0: 5.1.1 accepts solana-program >=1.14, <3.0 while the alpha requires 3.0, and the mismatch surfaced as expected __Pubkey, found a different __Pubkey where those programs bridge Metaplex's instruction types. This means the native token examples now compile against a prerelease Metaplex.
• external-delegate-token-master enabled the metadata feature without using it, so that came off.

The lints those crates had never been run through

Unused imports, needless borrows of .address() (which returns a reference already), .clone() on CpiHandle/CpiHandleMut (both Copy), mut on bindings that are already &mut, #[instruction(...)] parameters only a seeds expression reads, and three crates missing the unexpected_cfgs check-cfg declaration the rest of the repository carries.

Two needed more than the mechanical fix. DISCRIMINATOR_MAP, EXECUTE_DISCRIMINATOR and TX_HOOK_DISCRIMINATOR read as dead code because their only user is the #[cfg(target_os = "solana")] entrypoint the host build compiles out; they are gated the same way rather than deleted. create_collection's account fields were private, which made the one field no handler reads look unused; they are pub now, like every other accounts struct here.

One lint fix was a real bug, caught by the tests. Collapsing transfer_tokens_from_vault's eight arguments to six by passing the BorshAccount instead of the fields read event.event_id after release_borrow(), and BorshAccount's Deref panics once the borrow is released. All five betting-market tests failed with a panic inside serialized_account.rs. EventSigner now copies the view, ID and bump out while the borrow is live, which satisfies too_many_arguments and makes the ordering something a caller cannot get wrong.

Verification

101 workspace members resolve. cargo fmt --check and cargo clippy -- -D warnings -A clippy::diverging_sub_expression both clean across all of them.

---

Generated by Claude Code