test: drop dead Sec-Webtransport-Http3-Draft02 request header - #282
Open
tomholford wants to merge 1 commit into
Open
test: drop dead Sec-Webtransport-Http3-Draft02 request header#282tomholford wants to merge 1 commit into
tomholford wants to merge 1 commit into
Conversation
tomholford
marked this pull request as ready for review
June 14, 2026 03:13
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #282 +/- ##
=======================================
Coverage 82.37% 82.37%
=======================================
Files 8 8
Lines 993 993
=======================================
Hits 818 818
Misses 118 118
Partials 57 57 ☔ View full report in Codecov by Harness. |
Header-based draft version negotiation was removed in quic-go#191; the server no longer reads Sec-Webtransport-Http3-Draft02. The test helper was the only remaining reference in the tree, so setting it had no effect.
tomholford
force-pushed
the
drop-dead-draft02-test-header
branch
from
June 14, 2026 03:25
e6a5f31 to
62c950d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #280.
Sec-Webtransport-Http3-Draft02was the draft-02 header-based versionnegotiation mechanism, removed in #191. The server no longer reads it,
and after #280 the only remaining reference to it in the tree was this
test helper (
NewWebTransportRequest) — so setting the header had noeffect.
No behavior change: the helper still builds a valid WebTransport CONNECT
request.
Note
Remove dead
Sec-Webtransport-Http3-Draft02header fromNewWebTransportRequesttest helperDrops the
Sec-Webtransport-Http3-Draft02header from theNewWebTransportRequesthelper in test_helpers_test.go, which was no longer needed.Macroscope summarized 62c950d.