Skip to content

Complete conformance validation - #19

Open
zatevakhin wants to merge 1 commit into
stack/v0.0.2-05-videofrom
stack/v0.0.2-06-conformance
Open

Complete conformance validation#19
zatevakhin wants to merge 1 commit into
stack/v0.0.2-05-videofrom
stack/v0.0.2-06-conformance

Conversation

@zatevakhin

@zatevakhin zatevakhin commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Changes

  • add shared model-free and native C API acceptance gates
  • add model-free ASan, UBSan, and leak validation with exact fixture checks
  • align local and hosted acceptance through package and publish dry runs

Testing

  • nix develop -c just native-capi
  • env -u VLLM_CPP_TEST_MODEL nix develop -c just sanitizers-model-free
  • env -u VLLM_CPP_TEST_MODEL nix develop -c just ci

Summary by CodeRabbit

  • Quality Improvements

    • Expanded automated validation to cover native C API behavior, model-free workflows, sanitizers, packaging, documentation, and link checks.
    • Added Python support to development and verification environments.
    • Improved continuous integration coverage to detect memory-safety, undefined-behavior, and compatibility issues earlier.
  • Developer Experience

    • Added streamlined commands for running the project’s complete test and validation suite locally.

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 492f4f8e-4d63-4b23-baab-e53690ad0150

📥 Commits

Reviewing files that changed from the base of the PR and between e619c19 and edcec3f.

📒 Files selected for processing (3)
  • .github/workflows/ci.yml
  • Justfile
  • flake.nix

Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review.


📝 Walkthrough

Walkthrough

The change adds locked model-free tests, native C API fixture validation, and model-free sanitizer checks. CI installs Python support, runs the new gates, and makes packaging depend on native and sanitizer validation.

Changes

CI validation gates

Layer / File(s) Summary
Workspace and native validation targets
Justfile, .github/workflows/ci.yml, flake.nix
The Justfile adds locked model-free tests and a CPU-only native C API gate. CI and the development shell include Python 3.
Model-free sanitizer validation
Justfile, .github/workflows/ci.yml
The sanitizer target validates fixtures, builds selected binaries with AddressSanitizer and UBSan, and runs complete and focused test suites. CI runs this target in a dependent sanitizer job.
CI gate orchestration
Justfile, .github/workflows/ci.yml
The aggregate ci target runs the new checks. The native job runs C API fixtures, and packaging waits for native and sanitizer jobs.

Estimated code review effort: 4 (Complex) | ~45 minutes

Merge Risk: ⚪ Minimal · up to edcec

The PR adds conformance and sanitizer validation plus package and publish dry runs; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: adding complete conformance validation across model-free tests, native C API checks, sanitizer validation, packaging, and publication dry runs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch stack/v0.0.2-06-conformance

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant