Skip to content

Update raw bindings for vllm.cpp v0.0.2 - #13

Open
zatevakhin wants to merge 1 commit into
mainfrom
stack/v0.0.2-01-sys-abi
Open

Update raw bindings for vllm.cpp v0.0.2#13
zatevakhin wants to merge 1 commit into
mainfrom
stack/v0.0.2-01-sys-abi

Conversation

@zatevakhin

@zatevakhin zatevakhin commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Changes

  • pin vllm.cpp v0.0.2 and regenerate the ABI 17 bindings
  • cover all public layouts, signatures, and 35 exported C symbols
  • enforce ABI validation before by-value model defaults

Testing

  • nix develop -c just sys
  • sys and model-free safe API release tests
  • formatting and focused Clippy

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ed898793-f15d-425d-8d7c-d685fa107ae6

📥 Commits

Reviewing files that changed from the base of the PR and between 28ac8a7 and 86a16f3.

📒 Files selected for processing (13)
  • .github/workflows/platforms.yml
  • Justfile
  • vllm-cpp-sys/README.md
  • vllm-cpp-sys/THIRD_PARTY.md
  • vllm-cpp-sys/src/bindings.rs
  • vllm-cpp-sys/src/lib.rs
  • vllm-cpp-sys/tests/layout.c
  • vllm-cpp-sys/tests/layout.rs
  • vllm-cpp-sys/tests/symbols.rs
  • vllm-cpp-sys/vllm.cpp
  • vllm-cpp/src/engine.rs
  • vllm-cpp/src/lib.rs
  • vllm-cpp/tests/safe_api.rs

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The native vllm.cpp source advances to ABI 17. Rust bindings expose new completion, transcription, embedding, video, muxing, and server APIs. Tests validate layouts, symbols, ABI metadata, and checked model loading.

Changes

ABI 17 integration

Layer / File(s) Summary
Native ABI and FFI contract
.github/workflows/platforms.yml, vllm-cpp-sys/src/bindings.rs, vllm-cpp-sys/vllm.cpp, vllm-cpp-sys/README.md, vllm-cpp-sys/THIRD_PARTY.md, vllm-cpp-sys/src/lib.rs
The native pin advances to v0.0.2. The bindings target ABI 17 and add completion, transcription, embedding, video, muxing, and server declarations.
FFI layout and symbol conformance
vllm-cpp-sys/tests/layout.c, vllm-cpp-sys/tests/layout.rs, vllm-cpp-sys/tests/symbols.rs, Justfile
Tests validate new layouts, field offsets, status values, callback types, 35 exported symbols, server behavior, and ABI 17 smoke tests.
Checked ABI loading
vllm-cpp/src/engine.rs, vllm-cpp/src/lib.rs, vllm-cpp/tests/safe_api.rs
Engine loading checks ABI compatibility before calling the native model-parameter default function. Unit and safe API tests validate ABI 17 and the v0.0.2 version prefix.

Estimated code review effort: 4 (Complex) | ~45 minutes

Merge Risk: ⚪ Minimal · up to 86a16

The PR updates and validates the vllm.cpp v0.0.2 bindings and related tests; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 46.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 15 functions across 9 files. (4 skipped: … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the primary change: updating the raw bindings to vllm.cpp v0.0.2.
Full details: Docstring Coverage

Explanation

Docstring coverage is 46.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 15 functions across 9 files. (4 skipped: 4 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch stack/v0.0.2-01-sys-abi

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant