Skip to content

refactor: split the ACP subsystem - #95

Merged
zatevakhin merged 8 commits into
refactor/componentsfrom
refactor/acp-subsystem
Aug 27, 2026
Merged

refactor: split the ACP subsystem#95
zatevakhin merged 8 commits into
refactor/componentsfrom
refactor/acp-subsystem

Conversation

@zatevakhin

Copy link
Copy Markdown
Collaborator

Scope

  • Replace the ACP monolith with a focused facade and modules for commands, runtime, extensions, replay, notifications, elicitation, JSON-RPC, stdio, and WebSocket transport.
  • Isolate stdio, WebSocket, and JSON-RPC boundaries; preserve atomic replay/load buffering; separate notification translation, typed extensions, command routing, and elicitation handling.
  • Fix WebSocket teardown ordering so pending JSON-RPC failures are propagated and owned tasks drain before remaining work is aborted. The integrated shutdown_publishes_prompt_failure_before_returning regression test proves PromptFailed is published before run returns.
  • Phase 7 reducer work is explicitly excluded.

Review

Independent Linus review identified the WebSocket abort-before-fail defect, approved the lifecycle correction after re-review, and confirmed the final Clippy-only remediation is behavior-neutral and publication-ready.

Validation

  • cargo fmt --all -- --check passed
  • cargo check --all-targets --all-features passed
  • cargo clippy --all-targets --all-features -- -D warnings passed
  • cargo build --all-targets --all-features passed
  • cargo test --all-targets --all-features passed: 916 passed, 0 failed, 0 ignored
  • Focused WebSocket tests passed: 2/2
  • git diff --check 9d29638c60d53c533ac365ab2f4667186f105bde..HEAD passed

Environment limitation

External live stdio/WebSocket smoke testing was not run because no verified ACP agent binary or disposable endpoint was available. This is an environment gap, not successful smoke-test evidence.

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 69be43bd-814d-42e2-b9a8-abd234219cb5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@zatevakhin
zatevakhin merged commit e136869 into refactor/components Aug 27, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant