refactor: split the ACP subsystem - #95
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
shutdown_publishes_prompt_failure_before_returningregression test provesPromptFailedis published beforerunreturns.Review
Independent Linus review identified the WebSocket abort-before-fail defect, approved the lifecycle correction after re-review, and confirmed the final Clippy-only remediation is behavior-neutral and publication-ready.
Validation
cargo fmt --all -- --checkpassedcargo check --all-targets --all-featurespassedcargo clippy --all-targets --all-features -- -D warningspassedcargo build --all-targets --all-featurespassedcargo test --all-targets --all-featurespassed: 916 passed, 0 failed, 0 ignoredgit diff --check 9d29638c60d53c533ac365ab2f4667186f105bde..HEADpassedEnvironment limitation
External live stdio/WebSocket smoke testing was not run because no verified ACP agent binary or disposable endpoint was available. This is an environment gap, not successful smoke-test evidence.