Skip to content

refactor: centralize application effects - #94

Merged
zatevakhin merged 5 commits into
refactor/componentsfrom
refactor/application-effects
Aug 22, 2026
Merged

refactor: centralize application effects#94
zatevakhin merged 5 commits into
refactor/componentsfrom
refactor/application-effects

Conversation

@zatevakhin

Copy link
Copy Markdown
Collaborator

what changed

  • add a private application boundary with typed AppEvent, RuntimeEvent, and ordered Effect values
  • migrate key, mouse, ACP, connection, supervisor, tick, and runtime-result dispatch through application::update
  • move command dispatch, persistence, clipboard, external editor, terminal redraw, and quit handling to the runtime effect executor
  • preserve ACP/runtime channels, command payloads and ordering, persistence schema, status strings, and phase 4 state owners
  • reconcile the inherited duplicate application test modules into one focused 16-test suite

validation

  • cargo fmt --all -- --check
  • cargo check --all-targets --all-features
  • cargo clippy --all-targets --all-features -- -D warnings
  • cargo build --all-targets --all-features
  • cargo test --all-targets --all-features (902 passed)
  • git diff --check

boundary proof

  • exactly one private mod application, one AppEvent, one Effect, and one application::update
  • exactly eight phase 5 source files changed
  • zero command sender parameters, direct command sends, config writes, clipboard launches, pending command queues, or direct quit mutation in handlers
  • Command definitions and phase 6 ACP transport files are unchanged
  • App remains 13 direct fields; all 12 phase 4 owner modules remain private; four phase 11 compatibility forwards remain

@coderabbitai

coderabbitai Bot commented Aug 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5c1237a4-7923-49be-b2dc-e4b57cd79813

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@zatevakhin
zatevakhin merged commit 9d29638 into refactor/components Aug 22, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant