refactor: extract connection state - #89
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
change
ConnectionStateConnStateandServerStateinto the owner while keepingConnectionEvent,ServerEvent, runtime retry policy, transport, channels, endpoint selection, and process supervision at their existing boundariesexact base and scope
b8237b6959c44ad3f5d8486107c595add7dd326b3a7a599ff0fb04def35f2ba1591d3623dc5e9ba0c6ce4018b275f14e5eee0fb54d92ad8ed04c9f4dd8ad276refactor/componentssrc/connection_state.rs,src/lib.rs,src/app.rs,src/server_manager.rs,src/runtime/endpoint.rs,src/runtime/mod.rs,src/runtime/event_loop.rs,src/handlers.rs,src/session.rs,src/acp_state.rs, andsrc/ui/mod.rsvalidation
cargo fmt --all -- --checkcargo check --all-targets --all-featurescargo clippy --all-targets --all-features -- -D warningscargo build --all-targets --all-featurescargo test --all-targets --all-features— 859 passed, 0 failed (base: 848)git diff --checkboundary proof
mod connection_state;; no export or re-exportApp.connection: ConnectionState; owner has exactly five fields;Apphas 63 direct fieldsConnectionState,ConnState, andServerStateAppdeclarations or accesses for the extracted fields; no getter/facade/alias/Deref/second ownerConnectionEventremains inapp;ServerEventremains inserver_manager;ConnectionManagerEventandServerChannelMsgremain in runtimeruntime/connection.rs; ACP runtime launch cwd remains inacp_client.rsAppimplementation files, and fourphase 11 compatibility forwardtagsAGENTS.md,CLAUDE.md,REFACTOR.md, roadmap/history, runtime retry, transport, config, protocol, and domain files are absent from the source commitintegration into
refactor/componentsis still pending review and merge.