FROMLIST: ASoC: qcom: q6apm-lpass-dai: move graph start to trigger#474
Open
ks5-dev wants to merge 1 commit intoqualcomm-linux:qcom-6.18.yfrom
Open
FROMLIST: ASoC: qcom: q6apm-lpass-dai: move graph start to trigger#474ks5-dev wants to merge 1 commit intoqualcomm-linux:qcom-6.18.yfrom
ks5-dev wants to merge 1 commit intoqualcomm-linux:qcom-6.18.yfrom
Conversation
ks5-dev
requested review from
a team,
quic-tingweiz,
quicAspratap and
shashim-quic
shashim-quic
requested changes
Apr 16, 2026
shashim-quic
left a comment
shashim-quic
left a comment
There was a problem hiding this comment.
please add Link: tag. Refer other commit logs.
Start the graph at trigger callback. Staring the graph at prepare does not make sense as there is no data transfer at this point. Moving this to trigger will also help cope situation where pipewire is not happy if display port is not connected during start. Link: https://lore.kernel.org/all/20260402081118.348071-12-srinivas.kandagatla@oss.qualcomm.com/ Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com> Signed-off-by: Karthik S <karthik.s@oss.qualcomm.com>
ks5-dev
force-pushed
the
topic/ENABLE_DP_LEMANS_KODIAK
branch
from
c7f602f to
80c7d74
Compare
Author
ACK |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start the graph at trigger callback. Staring the graph at prepare does not make sense as there is no data transfer at this point. Moving this to trigger will also help cope situation where pipewire is not happy if display port is not connected during start.
Link: https://lore.kernel.org/all/20260402081118.348071-12-srinivas.kandagatla@oss.qualcomm.com/
CRs-Fixed: 4502072