WORKAROUND: arm64: dts: qcom: monaco: Disable refgen node to prevent …#954
Open
ziyuezhang-123 wants to merge 1 commit intoqualcomm-linux:tech/all/workaroundfrom
Open
WORKAROUND: arm64: dts: qcom: monaco: Disable refgen node to prevent …#954ziyuezhang-123 wants to merge 1 commit intoqualcomm-linux:tech/all/workaroundfrom
ziyuezhang-123 wants to merge 1 commit intoqualcomm-linux:tech/all/workaroundfrom
Conversation
…PCIe AER The node is currently enabled but not referenced by any consumer -- the DSI controller node does not carry a refgen-supply property. However, with the node enabled, the qcom-refgen-regulator driver probes it and registers a live regulator. When the DSI subsystem powers off, the driver writes to the REFGEN_REG_BIAS_EN and REFGEN_REG_BG_CTRL registers of AHB2PHY_3_PHY_REFGEN_3 (refgen_nxgen_3). Although refgen_nxgen_3 does not supply the PCIe PHY (refgen_nxgen_2 does), this register write inadvertently disturbs the PCIe PHY and triggers spurious PCIe AER (Advanced Error Reporting) errors. Disable the refgen node as a workaround to prevent the regulator driver from probing it. With the node disabled, no register writes reach AHB2PHY_3_PHY_REFGEN_3, and the PCIe AER errors are avoided. Signed-off-by: Ziyue Zhang <ziyue.zhang@oss.qualcomm.com>
qcomlnxci
requested review from
a team,
Komal-Bajaj,
rrnayak and
trsoni
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…PCIe AER
The node is currently enabled but not referenced by any consumer -- the DSI controller node does not carry a refgen-supply property. However, with the node enabled, the qcom-refgen-regulator driver probes it and registers a live regulator. When the DSI subsystem powers off, the driver writes to the REFGEN_REG_BIAS_EN and REFGEN_REG_BG_CTRL registers of AHB2PHY_3_PHY_REFGEN_3 (refgen_nxgen_3). Although refgen_nxgen_3 does not supply the PCIe PHY (refgen_nxgen_2 does), this register write inadvertently disturbs the PCIe PHY and triggers spurious PCIe AER (Advanced Error Reporting) errors.
Disable the refgen node as a workaround to prevent the regulator driver from probing it. With the node disabled, no register writes reach AHB2PHY_3_PHY_REFGEN_3, and the PCIe AER errors are avoided.