AvailabilityTimeOffset ignored for SSR

[cotid-qualabs]

Addresses comments #9 (comment) and #9 (comment)

[gemini-code-assist]

Summary of Changes

Hello @cotid-qualabs, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where the AvailabilityTimeOffset was not being correctly applied or respected in scenarios involving Server-Side Rendering (SSR). The changes involve refining the configuration parsing to prevent an incorrect reset of a related flag and reordering the segment writing logic to ensure that SSR-specific processing is correctly prioritized, thereby allowing AvailabilityTimeOffset to function as intended during SSR.

Highlights

• Configuration Flag Correction: Removed an explicit reset of AvailabilityTimeCompleteFlag when processing the chunkdurssr configuration, allowing its intended state to be maintained.
• Segment Writing Logic Reordering: Adjusted the order of conditional checks for SSRFlag and AvailabilityTimeCompleteFlag to ensure that Server-Side Rendering (SSR) specific segment writing takes precedence when SSRFlag is active, preventing AvailabilityTimeCompleteFlag from prematurely overriding SSR behavior.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request fixes an issue where Server-Side Rendering (SSR) was not triggered correctly by moving the SSR check to have higher priority. This change is correct. However, the related change in configurl.go seems to introduce a new bug where using the chunkdurssr parameter alone no longer results in chunked delivery. I've added a comment with a suggestion to fix this.

[gemini-code-assist]

By removing cfg.AvailabilityTimeCompleteFlag = false from this case, a new issue might be introduced. If chunkdurssr is used without ssras, SSRFlag will be false and AvailabilityTimeCompleteFlag will default to true. This leads to writeLiveSegment being called, which delivers a full segment instead of chunks, contrary to what chunkdurssr implies.

The previous behavior of falling back to writeChunkedSegment seems more correct.

If chunkdurssr is intended to enable SSR mode on its own, it should set SSRFlag to true. This seems like the most logical fix given the parameter name.

Suggested change

	cfg.ChunkDurSSR = val
	cfg.ChunkDurSSR = val
	cfg.SSRFlag = true