Fix chunking fallback

[cotid-qualabs]

Addressing comment #9 (comment)

[gemini-code-assist]

Summary of Changes

Hello @cotid-qualabs, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the logic for low-latency streaming by ensuring that chunked segment writing is only activated when an explicit chunk duration is provided. This change prevents unintended fallback to chunked mode with derived durations and instead defaults to standard live segment writing, making the system's behavior more predictable and robust. It also introduces an error state for cases where chunking is implicitly requested without the necessary configuration.

Highlights

• Explicit Chunking Control: Chunked low-latency mode is now only enabled if an explicit chunk duration (either ChunkDurS or ChunkDurSSR) is configured. Previously, it would attempt to use a calculated fallback duration.
• Fallback to Non-Chunked Live Segment: If no explicit chunk duration is set, the system will now default to writing a non-chunked live segment (writeLiveSegment) instead of attempting to use a derived chunk duration.
• Error for Unconfigured Chunking: The system will now return an error if chunking is requested (i.e., writeChunkedSegment is called) but no explicit chunk duration is configured, preventing unexpected behavior.
• Test Case Update: The TestWriteChunkedSegment was updated to explicitly set a ChunkDurS value, aligning the test with the new requirement for chunked mode activation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly addresses an issue where chunked transfer was the default behavior for low-latency streams. The changes ensure that chunking is now an opt-in feature, activated only when a chunk duration is explicitly specified through the chunkDurS or chunkDurSSR parameters. The fallback mechanism has been corrected to serve a complete segment, which is the appropriate default. Additionally, the error handling within prepareChunks has been improved for clarity, and the tests have been updated to reflect these new requirements. The implementation is clean and effectively resolves the problem.