feat(map): render MMS images inline in conversation (tincan-orn95)#57
Merged
Conversation
…4l6) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Fetch full MIME body for MMS messages via Attachment:True in Message1.Get
- Parse multipart MIME in _parse_mms_content: extract text/plain body and
base64-encode image/* attachments as a list of {mime_type, data} dicts
- Serialize attachments as JSON string through D-Bus sv dict and dbus_service
- ThreadView: decode attachments on MessageData, render each image in a
QLabel beneath the text bubble (max 300px wide, SmoothTransformation)
- GUI: parse attachments JSON in _on_message_received, _cache_msg_to_data,
_msg_dict_to_data; treat non-empty attachments as sufficient for display
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Owner
Author
Reviewer finding: request-changes1 blocker — fix is 2 lines / F1 [BLOCKER] Ruff violations in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Attachment:Truein BlueZMessage1.Get_parse_mms_content(): extracts text body and base64-encodes image attachments as[{mime_type, data}]svdict chain (dbus_service.py→ GUI)QLabel+QPixmap, max 300 px wide) beneath the message textTests
tests/tincand/test_parse_mms_content.py(tincan-cq4l6)Test plan
pytest— all 1116 tests pass🤖 Generated with Claude Code