feat(notifications): add reply + mark-read action buttons (tincan-5ptsg)#54
Merged
Conversation
…notifications (tincan-5ptsg) - DesktopNotifier: accept on_mark_read callback; expose 'Reply' and 'Mark as Read' action buttons in Notify() call - 'reply' action triggers on_action_invoked (open+select conversation) - 'mark-read' action triggers on_mark_read without raising the window - MainWindow: wire on_mark_read → _dbus_client.mark_conversation_read - 8 new tests covering button presence + callback routing Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DesktopNotifier.on_mark_read → MarkConversationReadon the daemon, without raising the windowon_mark_readconstructor param onDesktopNotifier;MainWindowwires it to_dbus_client.mark_conversation_readTest plan
tests/tincan_gui/test_desktop_notifications.py::TestActionableNotifications🤖 Generated with Claude Code