[7096][IMP] report_positioned_image: add domain to display image in specific record - #37
Open
AungKoKoLin1997 wants to merge 3 commits into
Open
[7096][IMP] report_positioned_image: add domain to display image in specific record#37AungKoKoLin1997 wants to merge 3 commits into
AungKoKoLin1997 wants to merge 3 commits into
Conversation
AungKoKoLin1997
requested review from
kanda999,
nobuQuartile,
smorita7749 and
yostashiro
August 31, 2026 06:01
The condition carried its own condition_model_id, which bound an image to one model: the same image had to be duplicated per model, and an image also placed on reports rendering another model printed there unguarded. Drop the field and evaluate the domain against the model the printed report renders. One image can then guard several reports as long as they share the field paths its domain uses, and it is left out of a report whose model the condition does not fit rather than printed unconditionally. Validation moves to the reports the image is placed on, and is enforced from both sides of the relation, so a wrong field path is still refused on write instead of surfacing during a print run. Assisted-by: Claude Opus 5
Contributor
Author
|
@yostashiro I added a new commit to fix the CI failing because of showing warning in the logging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QT7096